ECI-1126 [OCI] - Support Tag Defaults in OCI Quickstart#96
ECI-1126 [OCI] - Support Tag Defaults in OCI Quickstart#96EamonBrady1 wants to merge 6 commits intomasterfrom
Conversation
datadog-integration/locals.tf
Outdated
| for td in data.oci_identity_tag_defaults.compartment.tag_defaults : | ||
| "${local.tag_defaults_namespace_names[td.tag_namespace_id]}.${td.tag_definition_name}" => td.value |
There was a problem hiding this comment.
so, for tag defaults, does there always exist a value from the data block ? From what I can recall, some defaults can require a manual entry from the user creating the resource. Is that not the case ?
There was a problem hiding this comment.
Yes you are correct and I verified this behavior. Right now, the response returns "[CANNOT BE EMPTY]" if a tag key requires an input, but does not have a default value. So, right now I am using that as the entered value, to satisfy the constraints for creating the resource.
On a generated vcn when testing, one of the tags was "eamon-test.eamon:[CANNOT BE EMPTY]" as a result of this, which satisfied the constraint.
94ec7f0 to
6b7a90d
Compare
He is on PTO and I think his review is blocking the merge. I discussed this with him to confirm we're all set
What
Why
Customers can have tag defaults (see link below) requiring resources created in a compartment to have certain defined tags. This update automatically detects and applies those tags when necessary in the user's compartment.
The policy allowing Datadog to use defined tags is not conditional on whether or not the compartment has defined tags in order to remain future compatible, if the user eventually adds these, so that it will not break their integration.
Testing
https://www.ateam-oracle.com/oracle-cloud-infrastructure-tagging-best-practices-enable-mandatory-tagging-for-compartments